Add env var check for Windows ssh-agent pipe name #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds logic to use the SSH_AUTH_SOCK environment variable when selecting the SSH Agent named pipe on Windows. If the env var is unset then the default openssh-ssh-agent is used instead.
|
Thanks for the improvements, @jborean93! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds logic to use the SSH_AUTH_SOCK environment variable when selecting the SSH Agent named pipe on Windows. If the env var is unset then the default openssh-ssh-agent is used instead.
It turns out that
ssh.exeor other tools likessh-add.exeon Windows will use the value ofSSH_AUTH_SOCKenv var so this change replicates that behaviour. It also adds some extra checks on the value to ensure it is in the form or\\.\pipe\....