[Breaking] Drop support for RSA PKCS#1 PEM keys in favor of the OpenSSH format. #272
+5
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jborean93 fyi. |
…SH format.
As described in the README, this library embraces OpenSSH format when possible.
This drops support for the RSA PKCS#1 PEM ('RSA PRIVATE KEY') format which
was supported because the library author was using this format for a key.
If you are using a key in this format, it can be converted by running:
ssh-keygen -p -f <key_file>
The OpenSSH format has been supported in OpenSSH since 2014 and became
the default format used by 'ssh-keygen' in 2018.
tmds
force-pushed
the
drop_rsa_pem_key_support
branch
from
31b5c8f to
11a646f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the README, this library embraces OpenSSH format when possible.
This drops support for the RSA PKCS#1 PEM ('RSA PRIVATE KEY') format which was supported because the library author was using this format for a key.
If you are using a key in this format, it can be converted by running:
ssh-keygen -p -f <key_file>
The OpenSSH format has been supported in OpenSSH since 2014 and became the default format used by 'ssh-keygen' in 2018.