Implement ECDSA private key support #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the ability to use ECDSA private keys for user authentication. These keys support the NIST P_256, P_384, and P_521 curves that can be generated by ssh-keygen.
jborean93
commented
Jul 25, 2024
|
@jborean93, thanks for implementing this! I'll review it this week. |
tmds
reviewed
Jul 27, 2024
tmds
reviewed
Jul 28, 2024
tmds
reviewed
Jul 28, 2024
tmds
reviewed
Jul 28, 2024
|
Thanks @jborean93! |
|
Thanks for the speedy review and help with the MPInt handling! I'll rebase my encrypted key PR with the changes merged here, no rush on the review there though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to use ECDSA private keys for user authentication. These keys support the NIST P_256, P_384, and P_521 curves that can be generated by ssh-keygen.
Fixes: #203