Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

milvus: add skipFlushOnWrite option #992

Merged
merged 1 commit into from
Sep 13, 2024
Merged

milvus: add skipFlushOnWrite option #992

merged 1 commit into from
Sep 13, 2024

Conversation

fatedier
Copy link
Contributor

When importing a large number of documents at once, flushing during each AddDocuments can significantly increase the time taken.

In my scenario, I create a new collection, insert datas, and then replace the original collection, so there is no need to flush every time data is inserted.

Add an option skipFlushOnWrite to optimize this scenario. In my test scenario, the total time was reduced from 38 minutes to 5 minutes.

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

Copy link
Owner

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - consider linking to docs for this option.

@tmc tmc merged commit 0cab9df into tmc:main Sep 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants