Docker proxy config doesn't work on Ubuntu 15.04 #133

mrsheepuk · 2015-09-11T16:23:15Z

With the introduction of systemd, an extra step is required to make the proxy configuration work - analogous to the handling used for CoreOS whereby the systemd service unit is updated to pull in the environment from /etc/default/docker. I'm not experienced with Ruby so I may have made some large errors here, but this now works on my local environment against a ubuntu/vivid image.

mrsheepuk · 2015-09-11T16:30:50Z

Well that totally failed :) I've no idea how to update the tests but I'll give it a go.

mrsheepuk · 2015-09-11T16:40:20Z

Sorry I'm not sure how to fix this up - it looks like it's failed on a code complexity check rather than the tests as such, and I'm not sure how best to address this. If someone can point me in the right direction it would be appreciated!

otahi · 2015-09-11T22:09:16Z

@mrsheepuk Thank you for your trying a pull request!! It is very welcome!!
I will check it later. I feel it could be more simple, please give me time to check with ubuntu/vivid image.

otahi · 2015-09-12T22:14:48Z

@mrsheepuk I cannot reproduce the problem you indicated.. It means no problem for my proxy configuration with Docker on ubuntu/vivid.

I did vagrant up with ubuntu/vivid64, next installed dcoker.io, then did vagrant reload. That seems OK. What is the difference?

Vagrant and Vagrant-proxyconf version.

[otahi@otahiair vagrant-proxyconf-issue-133]$ vagrant -v
Vagrant 1.7.4
[otahi@otahiair vagrant-proxyconf-issue-133]$ vagrant plugin list | grep -i vagrant-proxyconf
vagrant-proxyconf (1.5.1)
[otahi@otahiair vagrant-proxyconf-issue-133]$

My vagrant file

[otahi@otahiair vagrant-proxyconf-issue-133]$ cat Vagrantfile
Vagrant.configure("2") do |config|
  config.vm.box = "ubuntu/vivid64"
  config.vbguest.auto_update = false
  config.vm.provider 'virtualbox' do |v|
    v.customize ['modifyvm', :id, '--memory', '256']
  end
  config.proxy.http     = "http://user:[email protected]:8080"
  config.proxy.https    = "http://user:[email protected]:8080"
  config.proxy.no_proxy = "/var/run/docker.sock"
end

vagrant reload log

[otahi@otahiair vagrant-proxyconf-issue-133]$ vagrant reload
==> default: Attempting graceful shutdown of VM...
==> default: Checking if box 'ubuntu/vivid64' is up to date...
==> default: Clearing any previously set forwarded ports...
==> default: Clearing any previously set network interfaces...
==> default: Preparing network interfaces based on configuration...
    default: Adapter 1: nat
==> default: Forwarding ports...
    default: 22 => 2222 (adapter 1)
==> default: Running 'pre-boot' VM customizations...
==> default: Booting VM...
==> default: Waiting for machine to boot. This may take a few minutes...
    default: SSH address: 127.0.0.1:2222
    default: SSH username: vagrant
    default: SSH auth method: private key
    default: Warning: Connection timeout. Retrying...
    default: Warning: Remote connection disconnect. Retrying...
==> default: Machine booted and ready!
==> default: Configuring proxy for Apt...
==> default: Configuring proxy for Docker...
==> default: Configuring proxy environment variables...
==> default: Checking for guest additions in VM...
==> default: Mounting shared folders...
    default: /vagrant => /Users/otahi/tmp/vagrant-proxyconf-issue-133
==> default: Machine already provisioned. Run `vagrant provision` or use the `--provision`
==> default: flag to force provisioning. Provisioners marked to run always will still run.
[otahi@otahiair vagrant-proxyconf-issue-133]$

Check proxy related environment variables.

[otahi@otahiair vagrant-proxyconf-issue-133]$ vagrant ssh -c 'sudo strings /proc/`sudo pgrep docker|head -n1`/environ | grep -i proxy '
HTTP_PROXY=http://user:[email protected]:8080
NO_PROXY=/var/run/docker.sock
http_proxy=http://user:[email protected]:8080
no_proxy=/var/run/docker.sock
Connection to 127.0.0.1 closed.
[otahi@otahiair vagrant-proxyconf-issue-133]$

And I checked systemd exists.

[otahi@otahiair vagrant-proxyconf-issue-133]$ vagrant ssh -c 'ps -p1 | grep systemd'    1 ?        00:00:01 systemd
Connection to 127.0.0.1 closed.
[otahi@otahiair vagrant-proxyconf-issue-133]$

mrsheepuk · 2015-09-14T09:21:18Z

@otahi Interesting - I'm using an ansible role https://github.com/angstwad/docker.ubuntu which installs the docker-engine package from the official docker repo, instead of the docker.io package from the ubuntu repos.

docker-engine is the package which the supported install process for ubuntu (https://docs.docker.com/installation/ubuntulinux/) - i.e. what you get if you run curl -sSL https://get.docker.com/ | sh

mrsheepuk · 2015-09-14T14:51:46Z

@otahi Here's the steps to reproduce:

vagrant init ubuntu/vivid64
# add proxy config to vagrant file if needed.
vagrant up
vagrant ssh

On the ssh term:

curl -sSL https://get.docker.com/ | sh
exit

Then do the vagrant reload. I've just tried this and the proxy config does not work. Retrying this process with my pull request in place correctly configures it - although I don't know whether it's the "best" way to configure it, it does work.

It's also possible to specify the proxy in a [Service] section in a .conf file in /etc/systemd/system/docker.service.d/ which provides a side-load extra piece of config for the service - e.g. in /etc/systemd/system/docker.service.d/http-proxy.conf this works:

[Service]
Environment="HTTP_PROXY=http://10.0.0.10:8080/" "HTTPS_PROXY=http://10.0.0.10:8080/"

I don't know how such a file would get created, but it's a very clean way of configuring the proxy as it doesn't involve any assumptions about the current configuration file for the systemd service.

otahi · 2015-09-14T20:54:35Z

@mrsheepuk Thank you for your quick response.

Now, I understand the installed docker package is different. I found the docker.io package reads /etc/default/docker in /lib/systemd/system/docker.service.

I will recheck with your steps.

/lib/systemd/system/docker.service in Docker's officaial package does not include /etc/default/docker.

otahi · 2015-09-16T01:21:37Z

@mrsheepuk I have added lib/vagrant-proxyconf/cap/debian/docker_proxy_conf.rb for Docker official package on Debian/Ubuntu. See otahi@b4f8689 on https://github.com/otahi/vagrant-proxyconf/tree/fix_ubuntu_docker. Can you check it?

mrsheepuk · 2015-09-16T06:48:04Z

I'll check it in a couple of hours time - thanks!

mrsheepuk · 2015-09-16T09:26:56Z

@otahi Thanks for this - I've just tested and it works fine on 15.04 with the official docker docker package now - however this will also apply to all versions of Debian / Ubuntu rather than just those using systemd (i.e. 15.04 onwards in Ubuntu, not sure about Debian versions but assume a similar situation there).

I've just spun up a 15.04 and 14.04 image, installed docker then done a vagrant reload - on 14.04 you now get the following error on the reload:

The following SSH command responded with a non-zero exit status.
Vagrant assumes that this means the command failed!

systemctl daemon-reload

Stdout from the command:

Stderr from the command:

stdin: is not a tty
bash: line 2: systemctl: command not found

In my pull request, I was guarding against this using this line:

elsif machine.communicate.test('ps -p1 | grep systemd')

... although that's not bullet-proof, it should catch the vast majority of cases.

…description

otahi · 2015-09-17T21:39:07Z

@mrsheepuk Thank you for your indication. Yes, your are right. I was missing that. I think following matrix should be tested. I am trying to coding and testing to fill this matrix.

Guest OS \ Package	docker.io package	docker official package
Debian/Ubuntu systemd
Debian/Ubuntu none systemd

otahi · 2015-09-18T00:38:37Z

@mrsheepuk I have implemented and tested partially.

Guest OS \ Package	docker.io package	docker official package
Debian/Ubuntu systemd		Ubuntu 15.04 ✅
Debian/Ubuntu none systemd	Ubuntu 14.04 ✅

~~I have not tested on none systemd systems.~~
If you are OK, please replace your commit to my commits with my PR mrsheepuk#1.

~~I will test it on none systemd systems in few days.~~
I will test missing part of the matrix in a few days.

I had misunderstood Ubuntu 14.04 systemd condition, so I changed some description.

otahi · 2015-09-19T21:59:58Z

@mrsheepuk I have tested the matrix. And all tests are OK.

Guest OS \ Package	docker.io package	docker official package
Debian/Ubuntu systemd	Ubuntu 15.04 ✅	Ubuntu 15.04 ✅
Debian/Ubuntu none systemd	Ubuntu 14.04 ✅	Ubuntu 14.04 ✅

mrsheepuk · 2015-09-19T22:03:00Z

@otahi Great, thanks - I'll pull in your commits and update the pull request.

Fix ubuntu docker

@otahi

…eb hosts.". This has been superceded by the pull request from @otahi. This reverts commit 690cb77.

Docker proxy config doesn't work on Ubuntu 15.04

otahi · 2015-09-19T22:31:12Z

@mrsheepuk Thank you so much! I appreciate your pull request!

mrsheepuk · 2015-09-19T22:39:13Z

@otahi no problem, thanks for doing the actual work to integrate it successfully!

Use the coreOS style configuration for systemd-based Ubuntu/Deb hosts.

690cb77

mrsheepuk mentioned this pull request Sep 11, 2015

vagrant 1.6.5+ docker 1.6.1 on Debian Testing does not seem to work #125

Closed

otahi self-assigned this Sep 11, 2015

otahi added the enhancement label Sep 11, 2015

Add Debian docker capability for Docker's official packege

b4f8689

/lib/systemd/system/docker.service in Docker's officaial package does not include /etc/default/docker.

otahi added 2 commits September 17, 2015 21:23

Check if systemd is used on guest machine

59c79d4

Check if EnvironmentFile description in src_file to avoid duplicated …

3eb9d30

…description

Support docker.io command

15582a5

otahi mentioned this pull request Sep 18, 2015

Fix ubuntu docker mrsheepuk/vagrant-proxyconf#1

Merged

otahi added 2 commits September 19, 2015 07:17

Refactor too complex docker_proxy_conf method

fd6e1ed

Fix incorrect configure file name for docker.io package

89b8bac

mrsheepuk and others added 2 commits September 19, 2015 23:05

Merge pull request #1 from otahi/fix_ubuntu_docker

730bb31

Fix ubuntu docker

Revert "Use the coreOS style configuration for systemd-based Ubuntu/D…

8e130b4

…eb hosts.". This has been superceded by the pull request from @otahi. This reverts commit 690cb77.

otahi added a commit that referenced this pull request Sep 19, 2015

Merge pull request #133 from mrsheepuk/master

7dae09e

Docker proxy config doesn't work on Ubuntu 15.04

otahi merged commit 7dae09e into tmatilai:master Sep 19, 2015

otahi added a commit to otahi/vagrant-proxyconf that referenced this pull request Sep 30, 2015

Add merged tmatilai#130, tmatilai#133 to CHANGELOG.md

2256f0c

TheNitek mentioned this pull request Nov 2, 2015

Docker proxy config doesn't work on CentOS 7.0.1406 #138

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Docker proxy config doesn't work on Ubuntu 15.04 #133

Docker proxy config doesn't work on Ubuntu 15.04 #133

mrsheepuk commented Sep 11, 2015

mrsheepuk commented Sep 11, 2015

mrsheepuk commented Sep 11, 2015

otahi commented Sep 11, 2015

otahi commented Sep 12, 2015

mrsheepuk commented Sep 14, 2015

mrsheepuk commented Sep 14, 2015

otahi commented Sep 14, 2015

otahi commented Sep 16, 2015

mrsheepuk commented Sep 16, 2015

mrsheepuk commented Sep 16, 2015

otahi commented Sep 17, 2015

otahi commented Sep 18, 2015

otahi commented Sep 19, 2015

mrsheepuk commented Sep 19, 2015

otahi commented Sep 19, 2015

mrsheepuk commented Sep 19, 2015

Docker proxy config doesn't work on Ubuntu 15.04 #133

Docker proxy config doesn't work on Ubuntu 15.04 #133

Conversation

mrsheepuk commented Sep 11, 2015

mrsheepuk commented Sep 11, 2015

mrsheepuk commented Sep 11, 2015

otahi commented Sep 11, 2015

otahi commented Sep 12, 2015

mrsheepuk commented Sep 14, 2015

mrsheepuk commented Sep 14, 2015

otahi commented Sep 14, 2015

otahi commented Sep 16, 2015

mrsheepuk commented Sep 16, 2015

mrsheepuk commented Sep 16, 2015

otahi commented Sep 17, 2015

otahi commented Sep 18, 2015

otahi commented Sep 19, 2015

mrsheepuk commented Sep 19, 2015

otahi commented Sep 19, 2015

mrsheepuk commented Sep 19, 2015