forked from webpack-contrib/extract-text-webpack-plugin
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
7 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1414036
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm hasn't that removed backwards compatibility for Webpack 1 users?
1414036
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@renarsvilnis That might be the case. I just was not sure if I am breaking anything with this change. The tests run fine, but maybe a test for this case is missing.
What I did think was that the 2.0.0 version of the plugin was intended to support only webpack2. At least the peerDependency of webpack@^2.1.0-beta.19 suggests that. But i was not sure about that so I did not file a PR.
With this change however a configuration like this works:
Without the change it is not able to find the extract-text-plugin loader and will fail with a cryptic message.