Skip to content

Commit

Permalink
Angular v1.2.20 support, closes item:783
Browse files Browse the repository at this point in the history
Manually enable Angular CSP mode as auto-detection triggers a harmless, though
nonetheless annoying CSP error.

CSP detection has also proved to be brittle.

Override Angular's Bower main block to include `angular-csp.css` so that Wiredep
can inject it for us.

See: angular/angular.js#8191
  • Loading branch information
tlvince committed Jul 25, 2014
1 parent 3343805 commit 43f8b10
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 4 deletions.
3 changes: 2 additions & 1 deletion app/index.html
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
<!doctype html>
<html ng-app="lmisChromeApp">
<html ng-app="lmisChromeApp" ng-csp>
<head>
<meta charset="utf-8">
<title>Nigeria LMIS</title>
<meta name="viewport" content="user-scalable=no, initial-scale=1, maximum-scale=1, minimum-scale=1, width=device-width, height=device-height">
<!-- build:css styles/vendor.css -->
<!-- bower:css -->
<link rel="stylesheet" href="bower_components/angular/angular-csp.css" />
<link rel="stylesheet" href="bower_components/font-awesome/css/font-awesome.css" />
<link rel="stylesheet" href="bower_components/bootstrap-css-only/css/bootstrap.css" />
<link rel="stylesheet" href="bower_components/bootstrap-theme-cosmo/cosmo.min.css" />
Expand Down
14 changes: 11 additions & 3 deletions bower.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "lmis-chrome",
"version": "0.10.4",
"dependencies": {
"angular": "1.2.19",
"angular": "~1.2.20",
"angular-bootstrap": "~0.11.0",
"font-awesome": "~4.1.0",
"angular-ui-router": "~0.2.10",
Expand All @@ -12,11 +12,11 @@
"bootstrap-theme-cosmo": "tlvince/bootstrap-theme-cosmo#4c161a6bf5bebe0ecfbef0771e053c8c5c2698c9",
"angularjs-nvd3-directives": "~0.0.7",
"angular-growl-v2": "~0.6.1",
"angular-animate": "1.2.19",
"angular-animate": "~1.2.20",
"chrome-platform-analytics": "GoogleChrome/chrome-platform-analytics#ea84600d1251fee9dd3fe274780f385d5d1c03f1"
},
"devDependencies": {
"angular-mocks": "1.2.19",
"angular-mocks": "~1.2.20",
"jasmine-as-promised": "~0.0.8",
"es5-shim": "~3.4.0"
},
Expand All @@ -36,5 +36,13 @@
"private": true,
"resolutions": {
"d3": "~3.4.1"
},
"overrides": {
"angular": {
"main": [
"angular.js",
"angular-csp.css"
]
}
}
}

0 comments on commit 43f8b10

Please sign in to comment.