-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing RSS properly #799
Merged
Fixing RSS properly #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (finally) fixes the RSS problems (e.g. #805).
_rss
folder to FranklinTemplatesrss_generator
How to use this before the release
In your
deploy.yml
script put the package spec:What changes on the user side
If you had at some point a working RSS feed, this should not require you to do anything special, things should just work (and if they don't, please say so).
One thing is that it is now recommended to explicitly set
in your
config.md
along with the mandatory definition ofwebsite_url
,website_description
(orwebsite_descr
) for instance:What the changes allow / how to benefit from them
The RSS feed is now fully customisable; it is created by doing:
where
head
comes from_rss/head.xml
a file that you control just like a_layout/*
file and which, if you don't have it, is copied from head.xml; likewise the items are generated from_rss/item.xml
a file that you control as well, see the default item.xmlconfig.md
file, for instance the variableswebsite_description
,website_url
etc.rss
variable.That's about it. You can see an example for JuliaGPU:
They use a
abstract
function which basically sets therss
variable seerss_description
; another, easier way would have been to define that variable explicitly and called{{rss}}
in the text 😄Adding full content to RSS item
There are two fields per RSS item: one is the
description
which should be a short description of what's on the page and another one iscontent:encoded
which is basically the full content of the page. You are allowed to:you cannot just set
content:encoded
.By default only the
description
is set, but you can add the full page HTML by addingrss_full_content=true
in yourconfig.md
(example).Validating your feed