Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tikz demo #1021

Merged
merged 5 commits into from
Apr 28, 2023
Merged

fix tikz demo #1021

merged 5 commits into from
Apr 28, 2023

Conversation

fkastner
Copy link
Contributor

This should fix the tikz demo.
But I commented out a part of the newest demo which, I think, breaks the later demos.

@tlienart
Copy link
Owner

Thanks, yeah I had tried Tectonic but it's not completely portable as per this issue:

(...)
Cannot locate artifact 'tectonic_bin' for aarch64-apple-darwin-libgfortran5-cxx11-julia_version+1.8.4 ...
(...)

I'll investigate the table one though and probably do the reverse; the table one should be fixable and added back, and the Tikz one should probably just be removed for now.

@fkastner
Copy link
Contributor Author

Another idea would be to migrate TikzPictures.jl to the tectonic.jll which nowadays seems to have good support.

Also: if the demo works on Github Pages then it's a valid demo for many people (those not with an M1 Mac). In my opinion, that still makes it very useful.

@tlienart
Copy link
Owner

I agree with this; what we can do is just add a condition based on the system type so that it doesn't break on my machine.

@fkastner
Copy link
Contributor Author

Does this now work for you?

@tlienart
Copy link
Owner

tlienart commented Apr 27, 2023

yes if you add an else clause that defines the environment in utils.jl

else
    env_tikzcd(_, _) = ""
end

thanks!

(PS: can you rebase on master as nightly is dropped from CI for now, thanks!)

@fkastner
Copy link
Contributor Author

Ok, this should be good now.

@tlienart tlienart merged commit 41369d8 into tlienart:master Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants