Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

Create react-mdl.d.ts #275

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create react-mdl.d.ts #275

wants to merge 1 commit into from

Conversation

PavelPZ
Copy link
Contributor

@PavelPZ PavelPZ commented Mar 29, 2016

Known problems:

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9d1405a on PavelPZ:master into 26b35f8 on tleunen:master.

@PavelPZ
Copy link
Contributor Author

PavelPZ commented Apr 1, 2016

@alexeyzimarev "What is the following code for?" is already explained.
"propTypes inheritance" is patched by hand.

@tleunen
Copy link
Owner

tleunen commented Apr 8, 2016

@alexeyzimarev could you check the description file? I'd like to have your input since I know nothing about typescript...

@PavelPZ
Copy link
Contributor Author

PavelPZ commented Apr 9, 2016

I included type inheritance to my generator for FABButton & IconButton (both inherits from the Button).
@tleunen, are there any other inheritances? After your confirmation I will prepare new PR with final .d.ts.

The only problem is with

"There is a collision in react-mdl x React.HTML&DOM atributes. So I removed those atributes from React definition and leave them in correct MDL form: onChange, label, size, title, value, rows."

Typescript team is working on possibility to override property definition in interface descendant. After solving this Typescript issue I will prepare more correct version. I thing that this problem is not crucial for now.

For @alexeyzimarev: the last version is here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants