Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

Drop shadows are broken #26

Closed
4 tasks done
bluepichu opened this issue Jan 2, 2017 · 3 comments
Closed
4 tasks done

Drop shadows are broken #26

bluepichu opened this issue Jan 2, 2017 · 3 comments
Assignees
@bluepichu
Labels
Bug PR Filed

Comments

@bluepichu
Copy link
Collaborator

bluepichu commented Jan 2, 2017 •
edited
Loading

  • If dropShadowDistance is too big, then drop shadows get cut off.
  • dropShadowBlur seems to do nothing at all.
  • If one text style has a drop shadow that should be behind previous text, it is instead drawn on top of the previous text.
  • dropShadowAngle is measured from the wrong base angle.
@bluepichu bluepichu added the Bug label Jan 2, 2017
@bluepichu
Copy link
Collaborator Author

Turns out the distance-related bug is also present in PIXI.Text, but I'll do my best to find a fix anyway.

@bluepichu
Copy link
Collaborator Author

bluepichu commented Jan 13, 2017 •
edited
Loading

Actually, all of the issues here seem to be issues in PIXI.Text as well, in addition to some others. This is rendered with a PIXI.Text:

screenshot 2017-01-13 17 40 30

I also noticed two additional problems, which I added to the checklist above.

bluepichu added a commit to bluepichu/pixi-multistyle-text that referenced this issue Jan 13, 2017
@bluepichu
[Partial tleunen#26] Fix dropShadowBlur
f8447c3
bluepichu added a commit to bluepichu/pixi-multistyle-text that referenced this issue Jan 13, 2017
@bluepichu
[Partial tleunen#26] Don't draw shadows on top of text
343a25d
bluepichu added a commit to bluepichu/pixi-multistyle-text that referenced this issue Jan 13, 2017
@bluepichu
[Fixes tleunen#26] Do not cut off text shadow
a20fe2a
@bluepichu
Copy link
Collaborator Author

PR Filed: See #36.

@bluepichu bluepichu self-assigned this Jan 14, 2017
bluepichu added a commit to bluepichu/pixi-multistyle-text that referenced this issue Jan 16, 2017
@bluepichu
[Partial tleunen#26] Fix dropShadowBlur
10eb3c1
bluepichu added a commit to bluepichu/pixi-multistyle-text that referenced this issue Jan 16, 2017
@bluepichu
[Partial tleunen#26] Don't draw shadows on top of text
2790d46
bluepichu added a commit to bluepichu/pixi-multistyle-text that referenced this issue Jan 16, 2017
@bluepichu
[Fixes tleunen#26] Do not cut off text shadow
763f0ac
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bluepichu bluepichu

Labels
Bug PR Filed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bluepichu