Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

base64: fix German translation #9072

Merged
merged 1 commit into from
Oct 15, 2022
Merged

base64: fix German translation #9072

merged 1 commit into from
Oct 15, 2022

Conversation

pixelcmtd
Copy link
Member

I really don't wanna sound hostile towards the reviewers of #8767, but did you even read it?

@pixelcmtd pixelcmtd added page edit Changes to an existing page(s). translation Issues requesting translating pages from English to other languages. minor change Change(s) to an existing page(s) which is minor. labels Oct 15, 2022
@kbdharun
Copy link
Member

kbdharun commented Oct 15, 2022 •
edited
Loading

I really don't wanna sound hostile towards the reviewers of #8767, but did you even read it?

Sorry for the mishap. Will be more careful in German reviews in future. I made comments regarding this in #8767 (comment) in the wrong place and I will be more careful. I go through all the PR pages before giving an approving review. Regarding translations, I could only request changes but when a native speaker opposes it, then it lies outside my scope. Also, sometimes some words skip through our oversight when tools like Google translate aren't giving proper fixes to translations. Can you suggest me a tool for validating German translations and checking imperative mode?

I will request reviews from you in future. Thanks for fixing it in this PR.

Me and @navarroaxel try requesting reviews from the German team (a team) for most German translation PRs but to no avail. So we had to review it ourselves as PRs are piling up.

@pixelcmtd
Copy link
Member Author

Can you suggest me a tool for validating German translations?

I can suggest you learn German, but I wouldn't recommend it, wasting all of that time and brain space on category theory sounds like a much better (and more fun) idea 😆

I've always heavily disliked the idea of reviewing pages in languages that you do not speak, which is why I don't do it. But I can see that it's sometimes hard to avoid, especially when other collaborators are unreachable. However, I'm really interested in what I need to do to get into the German team.

@navarroaxel navarroaxel changed the title base64: fix german translation base64: fix German translation Oct 15, 2022
@navarroaxel navarroaxel merged commit 03fcf46 into tldr-pages:main Oct 15, 2022
@kbdharun
Copy link
Member

However, I'm really interested in what I need to do to get into the German team.

@navarroaxel can you add @pixelcmtd to German (a team).

@pixelcmtd pixelcmtd deleted the base64 branch December 25, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbdharun kbdharun kbdharun approved these changes

@navarroaxel navarroaxel navarroaxel approved these changes

Assignees
No one assigned
Labels
minor change Change(s) to an existing page(s) which is minor. page edit Changes to an existing page(s). translation Issues requesting translating pages from English to other languages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pixelcmtd @kbdharun @navarroaxel