Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ip-rule: add page #6504

Merged
merged 8 commits into from
Sep 15, 2021
Merged

ip-rule: add page #6504

merged 8 commits into from
Sep 15, 2021

Conversation

nobiit
Copy link
Contributor

@nobiit nobiit commented Sep 12, 2021

  • The page (if new), does not already exist in the repository.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@CLAassistant
Copy link

CLAassistant commented Sep 12, 2021

CLA assistant check
All committers have signed the CLA.

@marchersimon marchersimon added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Sep 12, 2021
pages/linux/ip-rule.md Show resolved Hide resolved
pages/linux/ip-rule.md Outdated Show resolved Hide resolved
pages/linux/ip-rule.md Outdated Show resolved Hide resolved
pages/linux/ip-rule.md Outdated Show resolved Hide resolved
pages/linux/ip-rule.md Outdated Show resolved Hide resolved
pages/linux/ip-rule.md Outdated Show resolved Hide resolved
pages/linux/ip-rule.md Outdated Show resolved Hide resolved
@navarroaxel navarroaxel changed the title ip rule: add Page ip-rule: add page Sep 12, 2021
@nobiit
Copy link
Contributor Author

nobiit commented Sep 12, 2021

Hey @marchersimon , Thank you for your time. Can you review one more time ?

Copy link
Collaborator

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two more things from me.
Also you don't have to force push, we sqash all commits anyways.

pages/linux/ip-rule.md Outdated Show resolved Hide resolved
pages/linux/ip-rule.md Outdated Show resolved Hide resolved
nobiit and others added 2 commits September 13, 2021 02:44
@nobiit
Copy link
Contributor Author

nobiit commented Sep 12, 2021

Okay, thanks @marchersimon for helping a lot

pages/linux/ip-rule.md Outdated Show resolved Hide resolved
pages/linux/ip-rule.md Outdated Show resolved Hide resolved
nobiit and others added 2 commits September 13, 2021 03:26
pages/linux/ip-rule.md Outdated Show resolved Hide resolved
Co-authored-by: Starbeamrainbowlabs <[email protected]>
@nobiit nobiit requested a review from sbrl September 14, 2021 19:50
pages/linux/ip-rule.md Outdated Show resolved Hide resolved
@nobiit nobiit requested a review from sbrl September 15, 2021 03:20
@tldr-bot

This comment has been minimized.

pages/linux/ip-rule.md Outdated Show resolved Hide resolved
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nobiit!

@sbrl sbrl merged commit 3447744 into tldr-pages:main Sep 15, 2021
@Managor Managor mentioned this pull request Jan 24, 2025
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants