Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-show-index: add page #5940

Merged
merged 10 commits into from
Jun 23, 2021
Merged

git-show-index: add page #5940

merged 10 commits into from
Jun 23, 2021

Conversation

Waples
Copy link
Member

@Waples Waples commented May 11, 2021

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Ref: #3953

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/git-show-index.md:6: TLDR104 Example descriptions should prefer infinitive tense (e.g. write) over present (e.g. writes) or gerund (e.g. writing)

Please fix the error(s) and push again.

@Waples Waples mentioned this pull request May 11, 2021
Open
@Waples Waples added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label May 11, 2021
sbrl
sbrl requested changes May 14, 2021
View reviewed changes
pages/common/git-show-index.md Outdated Show resolved Hide resolved
pages/common/git-show-index.md Outdated Show resolved Hide resolved
pages/common/git-show-index.md Outdated Show resolved Hide resolved
pages/common/git-show-index.md Outdated Show resolved Hide resolved
Waples and others added 4 commits May 23, 2021 02:04
@navarroaxel navarroaxel requested review from sbrl and bl-ue May 23, 2021 01:45
@github-actions
Copy link

github-actions bot commented Jun 8, 2021

Hi all! This thread has not had any recent activity.
Are there any updates? Thanks!

@github-actions github-actions bot added the waiting Issues/PRs with Pending response by the author. label Jun 8, 2021
@CleanMachine1
Copy link
Member

@Waples
Are you going to attend this PR?
I'll take over if needed/you give permission.

@github-actions github-actions bot removed the waiting Issues/PRs with Pending response by the author. label Jun 9, 2021
@Waples
Copy link
Member Author

Waples commented Jun 9, 2021

@Waples
Are you going to attend this PR?
I'll take over if needed/you give permission.

I've been in hospital the last few days, I'll pick this up later this week

@bl-ue
Copy link
Contributor

bl-ue commented Jun 9, 2021

No worries @Waples — we all have life and you should give it enough attention. We'll take care of your tldr-page "responsibilities" :)

sbrl
sbrl approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me after @marchersimon's comment is addressed

@bl-ue bl-ue merged commit 4d63c00 into tldr-pages:main Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CleanMachine1 CleanMachine1 CleanMachine1 left review comments

@marchersimon marchersimon marchersimon left review comments

@bl-ue bl-ue bl-ue approved these changes

@sbrl sbrl sbrl approved these changes

@navarroaxel navarroaxel navarroaxel approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Waples @tldr-bot @CleanMachine1 @bl-ue @navarroaxel @sbrl @marchersimon