Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-mailinfo: add page #5939

Merged
merged 9 commits into from
May 23, 2021
Merged

git-mailinfo: add page #5939

merged 9 commits into from
May 23, 2021

Conversation

Waples
Copy link
Member

@Waples Waples commented May 11, 2021

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Ref: #3953

@Waples Waples changed the title Git mailinfo git-mailinfo: add page May 11, 2021
@Waples Waples mentioned this pull request May 11, 2021
Open
bl-ue
bl-ue reviewed May 11, 2021
View reviewed changes
pages/common/git-mailinfo.md Outdated Show resolved Hide resolved
pages/common/git-mailinfo.md Outdated Show resolved Hide resolved
pages/common/git-mailinfo.md Outdated Show resolved Hide resolved
pages/common/git-mailinfo.md Outdated Show resolved Hide resolved
pages/common/git-mailinfo.md Outdated Show resolved Hide resolved
pages/common/git-mailinfo.md Outdated Show resolved Hide resolved
pages/common/git-mailinfo.md Outdated Show resolved Hide resolved
@Waples Waples added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label May 11, 2021
bl-ue
bl-ue reviewed May 11, 2021
View reviewed changes
Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

bl-ue
bl-ue reviewed May 11, 2021
View reviewed changes
Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Darn, I keep hitting Cmd+Enter which comments instead of approves 🙄

marchersimon
marchersimon approved these changes May 12, 2021
View reviewed changes
Copy link
Collaborator

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Waples

sbrl
sbrl reviewed May 14, 2021
View reviewed changes
pages/common/git-mailinfo.md

- Extract the patch and author data from an email message:

`git mailinfo {{message|patch}}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a path to a file, or something else? Same for the other examples.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mailinfo is very obscure. It's one of those git functions that's not very well documented and I haven't been able to test it out properly yet.

CleanMachine1
CleanMachine1 approved these changes May 17, 2021
View reviewed changes
Copy link
Member

@CleanMachine1 CleanMachine1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bl-ue bl-ue requested a review from sbrl May 17, 2021 13:17
@Waples Waples merged commit 1c6098b into tldr-pages:main May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bl-ue bl-ue bl-ue approved these changes

@CleanMachine1 CleanMachine1 CleanMachine1 approved these changes

@marchersimon marchersimon marchersimon approved these changes

@sbrl sbrl Awaiting requested review from sbrl

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Waples @sbrl @marchersimon @bl-ue @CleanMachine1