Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apt-*: add more info links; apt-file: add regex search example #5710

Merged
merged 19 commits into from
Apr 17, 2021

Conversation

patricedenis
Copy link
Collaborator

@patricedenis patricedenis commented Apr 8, 2021

Related: #5510

@tldr-bot
Copy link

tldr-bot commented Apr 8, 2021

The build for this PR failed with the following error(s):

pages/linux/apt-file.md:19: TLDR103 Command example is missing its closing backtick
pages/linux/apt-key.md:4: TLDR004 Command descriptions should end in a period
pages/linux/apt-key.md:5: TLDR003 Descriptions should start with a capital letter

Please fix the error(s) and push again.

@patricedenis
Copy link
Collaborator Author

#5510

@patricedenis
Copy link
Collaborator Author

I placed manned.org links as I understood we do now in #5143. Or I am supposed to link to the official Debian latest man pages?

@patricedenis
Copy link
Collaborator Author

patricedenis commented Apr 8, 2021

pages/linux/apt-key.md Outdated Show resolved Hide resolved
@bl-ue bl-ue added mass changes Changes that affect multiple pages. page edit Changes to an existing page(s). labels Apr 8, 2021
@bl-ue
Copy link
Contributor

bl-ue commented Apr 8, 2021

@patricedenis will you please also update the translations with this info (at least the links)? Feel free to set-more-info-link.py for that. Usage:

python3 set-more-info-link.py -p platform/page.md "https://new.link"
# e.g.
python3 set-more-info-link.py -p linux/apt.md "https://manned.org/apt.8"

The nice thing about it as that it will add the link to all of the translations of the page, in the page's language.

@patricedenis
Copy link
Collaborator Author

oh great !

@patricedenis
Copy link
Collaborator Author

I'm not sure for my history of commit cause I made some commits from Web interface and pull them after that to local git structure which did not catch them as single one but as a whole merge commit. So I split them up after that but the original commit hashes are lost even if I have rewritten the content.
I'm not sure I clear as well here ^^.

@patricedenis patricedenis requested a review from bl-ue April 8, 2021 16:16
@bl-ue
Copy link
Contributor

bl-ue commented Apr 8, 2021

No problem @patricedenis, it really doesn't matter what the commits look like as long as the files look the way we want them to in the end.

pages/linux/apt-key.md Outdated Show resolved Hide resolved
@bl-ue bl-ue changed the title apt-tools: add more info links and update apt-file apt-*: add more info links and update apt-file Apr 8, 2021
@bl-ue bl-ue changed the title apt-*: add more info links and update apt-file apt-*: add more info links; apt-file: add regex search example Apr 8, 2021
@bl-ue bl-ue added the translation Issues requesting translating pages from English to other languages. label Apr 8, 2021
@bl-ue
Copy link
Contributor

bl-ue commented Apr 8, 2021

I'll link this PR in #5510

@bl-ue
Copy link
Contributor

bl-ue commented Apr 8, 2021

@patricedenis will you please also add the link to apt-mark.md?

@patricedenis
Copy link
Collaborator Author

I'll link this PR in #5510

done it already in the first comment ^^

@patricedenis
Copy link
Collaborator Author

done, I forgot it thanks!

@patricedenis patricedenis requested a review from bl-ue April 8, 2021 21:05
Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice good batch of links, thank you @patricedenis.

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thanks so much for this.

Considering that apt is a debian-specific command though, wouldn't The Debian man pages be preferable here? e.g. https://manpages.debian.org/apt/apt-mark.8.en.html.

@patricedenis
Copy link
Collaborator Author

I'm OK with that. I just did'nt get where do we need to apply the manned.org links.
When we have some distribution specific command we ink to the distribution official man pages?

@patricedenis
Copy link
Collaborator Author

In that case, I should update all the links to the Debian man pages, I checked they're all included.
What do you think?

@patricedenis patricedenis requested a review from sbrl April 11, 2021 16:13
pages.de/linux/apt-add-repository.md Outdated Show resolved Hide resolved
pages.de/linux/apt-get.md Outdated Show resolved Hide resolved
pages.de/linux/apt.md Outdated Show resolved Hide resolved
pages.es/linux/apt-add-repository.md Outdated Show resolved Hide resolved
pages.es/linux/apt-cache.md Outdated Show resolved Hide resolved
pages/linux/apt-get.md Outdated Show resolved Hide resolved
pages/linux/apt-key.md Outdated Show resolved Hide resolved
pages/linux/apt-mark.md Outdated Show resolved Hide resolved
pages/linux/apt.md Outdated Show resolved Hide resolved
pages/linux/aptitude.md Outdated Show resolved Hide resolved
@sbrl
Copy link
Member

sbrl commented Apr 15, 2021

Haha wow @navarroaxel, that was a lot of comments? Perhaps next time in this instance it might have been better and less overwhelming to leave 1 generic comment?

@patricedenis: I've taken the liberty of making the more information links you've added language-agnostic, if that's ok?

For future reference, the find-in-files feature of GitHub's Atom works splendidly for this.

@patricedenis
Copy link
Collaborator Author

@sbrl no problemo, thanks !

For future reference, the find-in-files feature of GitHub's Atom works splendidly for this.

OK, I didn't know the function. I will try it next time. thanks again !

And a big thank you as well to @navarroaxel for the complete review !

@bl-ue bl-ue requested a review from navarroaxel April 17, 2021 11:57
@navarroaxel navarroaxel merged commit ca8394d into tldr-pages:master Apr 17, 2021
@patricedenis patricedenis deleted the apt-tools-update branch April 18, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mass changes Changes that affect multiple pages. page edit Changes to an existing page(s). translation Issues requesting translating pages from English to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants