Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-range-diff: add page #5701

Merged
merged 5 commits into from
May 28, 2021
Merged

git-range-diff: add page #5701

merged 5 commits into from
May 28, 2021

Conversation

xeruf
Copy link
Contributor

@xeruf xeruf commented Apr 7, 2021 •
edited
Loading

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Helpful SO link for reference:
https://stackoverflow.com/questions/52323008/can-somebody-explain-the-usage-of-git-range-diff

@tldr-bot
Copy link

tldr-bot commented Apr 7, 2021

The build for this PR failed with the following error(s):

Error: Parse error on line 4:
...docs/git-range-diff>- Diff the diffs o
-----------------------^
Expecting 'END_INFORMATION_LINK_URL', got 'NEWLINE'
pages/common/git-range-diff.md:3: TLDR004 Command descriptions should end in a period
pages/common/git-range-diff.md:4: TLDR011 Page never contains more than a single empty line

Please fix the error(s) and push again.

@tldr-bot
Copy link

tldr-bot commented Apr 7, 2021

The build for this PR failed with the following error(s):

Error: Parse error on line 4:
...docs/git-range-diff>- Diff the diffs o
-----------------------^
Expecting 'END_INFORMATION_LINK_URL', got 'NEWLINE'
pages/common/git-range-diff.md:3: TLDR004 Command descriptions should end in a period
pages/common/git-range-diff.md:4: TLDR011 Page never contains more than a single empty line

Please fix the error(s) and push again.

@bl-ue bl-ue added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Apr 7, 2021
@navarroaxel navarroaxel changed the title git-range-diff: add common page git-range-diff: add page Apr 12, 2021
@marchersimon marchersimon mentioned this pull request Apr 13, 2021
Open
@navarroaxel navarroaxel requested a review from bl-ue April 25, 2021 05:13
@Waples
Copy link
Member

Waples commented Apr 28, 2021

bump @bl-ue

@github-actions
Copy link

Hi all! This thread has not had any recent activity.
Are there any updates? Thanks!

@github-actions github-actions bot added the waiting Issues/PRs with Pending response by the author. label May 17, 2021
@bl-ue bl-ue removed the waiting Issues/PRs with Pending response by the author. label May 17, 2021
@Waples
Copy link
Member

Waples commented May 17, 2021

@bl-ue you gonna review this again or is it ready?

@CleanMachine1
Copy link
Member

We should look at the existing unresolved review bl-ue has left, I have added my input on it as well

@bl-ue
Copy link
Contributor

bl-ue commented May 17, 2021 •
edited
Loading

@CleanMachine1 stalebot ignore is used for labels that we're ignoring because of stuff like waiting for linter updates, etc.

@CleanMachine1 CleanMachine1 added the waiting Issues/PRs with Pending response by the author. label May 18, 2021
@CleanMachine1
Copy link
Member

The tag is needed. It has been 30 days since latest reply

@github-actions github-actions bot removed the waiting Issues/PRs with Pending response by the author. label May 19, 2021
@xeruf
Copy link
Contributor Author

xeruf commented May 19, 2021

Ready to merge imo

@bl-ue bl-ue requested a review from CleanMachine1 May 19, 2021 13:58
@CleanMachine1
Copy link
Member

still an unfinished review and my new one

@CleanMachine1
Copy link
Member

I'd like to dismiss simons review and get another one since its very out of date and I am not sure what his person opinion on this currently is

@bl-ue bl-ue requested review from Waples and marchersimon May 19, 2021 16:29
marchersimon
marchersimon approved these changes May 19, 2021
View reviewed changes
Copy link
Collaborator

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @xeruf

sbrl
sbrl approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me. This PR has been sitting around for a while and I think it's as good as it's going to get, so let's merge it as-is.

@marchersimon marchersimon merged commit 7aefc85 into tldr-pages:main May 28, 2021
@xeruf xeruf deleted the patch-1 branch June 5, 2021 15:51
@xeruf
Copy link
Contributor Author

xeruf commented Jun 5, 2021

Thanks :) I only check-in every few weeks on such projects since I have other more important projects my plate, with PRs like this being little side-strolls ;)

@bl-ue
Copy link
Contributor

bl-ue commented Jun 5, 2021

with PRs like this being little side-strolls ;)

And they shouldn't be anything else 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CleanMachine1 CleanMachine1 CleanMachine1 left review comments

@bl-ue bl-ue bl-ue approved these changes

@marchersimon marchersimon marchersimon approved these changes

@sbrl sbrl sbrl approved these changes

@navarroaxel navarroaxel Awaiting requested review from navarroaxel

@Waples Waples Awaiting requested review from Waples

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@xeruf @tldr-bot @Waples @CleanMachine1 @bl-ue @navarroaxel @sbrl @marchersimon