Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-commit-tree: add page #5113

Merged
merged 4 commits into from
Jan 8, 2021
Merged

git-commit-tree: add page #5113

merged 4 commits into from
Jan 8, 2021

Conversation

bl-ue
Copy link
Contributor

@bl-ue bl-ue commented Jan 7, 2021

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

For #3953

@bl-ue bl-ue added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Jan 7, 2021
@bl-ue bl-ue mentioned this pull request Jan 7, 2021
Open
@bl-ue @sbrl
Update pages/common/git-commit-tree.md
131bda2 
Co-authored-by: Starbeamrainbowlabs <[email protected]>
@bl-ue bl-ue requested a review from sbrl January 7, 2021 22:38
navarroaxel
navarroaxel reviewed Jan 8, 2021
View reviewed changes
pages/common/git-commit-tree.md Outdated Show resolved Hide resolved
pages/common/git-commit-tree.md Outdated Show resolved Hide resolved
pages/common/git-commit-tree.md Outdated Show resolved Hide resolved
@bl-ue @navarroaxel
Apply suggestions from code review
d2c8a67 
Still learning :D

Co-authored-by: Axel Navarro <[email protected]>
@bl-ue bl-ue requested a review from navarroaxel January 8, 2021 12:12
@bl-ue bl-ue merged commit bae2dd0 into master Jan 8, 2021
@bl-ue bl-ue deleted the git/commit-tree branch January 8, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schneiderl schneiderl schneiderl approved these changes

@navarroaxel navarroaxel navarroaxel approved these changes

@sbrl sbrl Awaiting requested review from sbrl

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bl-ue @navarroaxel @sbrl @schneiderl