-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git-replace, w: add pages #4496
Conversation
show who is logged in and their processes.
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
fixed basic typos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @unknown1924, thanks! I left some comments.
changed to long argument format. Co-authored-by: Axel Navarro <[email protected]>
changed to long argument format. Co-authored-by: Axel Navarro <[email protected]>
Improved readability. Co-authored-by: Axel Navarro <[email protected]>
Co-authored-by: Axel Navarro <[email protected]>
Co-authored-by: Axel Navarro <[email protected]>
Co-authored-by: Axel Navarro <[email protected]>
Thanks for the suggestions! I've made the changed as per the suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new page, @unknown1924! I've left some comments below for you to review.
Co-authored-by: Starbeamrainbowlabs <[email protected]>
Co-authored-by: Starbeamrainbowlabs <[email protected]>
Co-authored-by: Starbeamrainbowlabs <[email protected]>
added suggestions Co-authored-by: Starbeamrainbowlabs <[email protected]>
added page for git-replace command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move git-replace.md
to another PR. This was only for w
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there, @unknown1924! Looks like something's gone skew here, as I'm now seeing an extra page here for git replace
. Thanks so much for the contribution! Next time though, it would be great if you could open a separate pull request for that, as it's going to draw out the review process here and prevent the w
page you've written from being merged until we've reviewed and accepted git replace
too.
Anyway, I've left some comments below for you to review about git replace
🙂
Co-authored-by: Axel Navarro <[email protected]>
Co-authored-by: Starbeamrainbowlabs <[email protected]>
Co-authored-by: Starbeamrainbowlabs <[email protected]>
I'm not sure how this PR for git-replace came here. |
@unknown1924 Looks like you push that commit to this branch lol things happens 🤷♂️
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @unknown1924 😺
I'm so sorry I didn't address the issue earlier, had some exams so a bit busy. |
No worries, @unknown1924! Glad it's been a learning experience - we hope you'll come back with another PR soon :-) |
w command shows who is logged in and their processes.
common/
,linux/
, etc.)