Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-cherry: add page #4473

Merged
merged 1 commit into from
Oct 7, 2020
Merged

git-cherry: add page #4473

merged 1 commit into from
Oct 7, 2020

Conversation

Amorymeltzer
Copy link
Contributor

Requested in #3953.


Opened as a draft as (IMO) the language feels a bit awkward, and would welcome suggestions.

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@tldr-bot
Copy link

tldr-bot commented Oct 4, 2020

The build for this PR failed with the following error(s):

pages/common/git-cherry.md:3: TLDR004 Command descriptions should end in a period

Please fix the error(s) and push again.

@navarroaxel navarroaxel added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Oct 4, 2020
@navarroaxel navarroaxel changed the title git-cherry: Add page git-cherry: add page Oct 4, 2020
@navarroaxel navarroaxel requested a review from sbrl October 4, 2020 13:25
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new page, @Amorymeltzer! I've left some comments below for you to review. Hopefully I haven't changed the meaning too much 🙂

pages/common/git-cherry.md Outdated Show resolved Hide resolved
pages/common/git-cherry.md Outdated Show resolved Hide resolved
@Amorymeltzer Amorymeltzer marked this pull request as ready for review October 5, 2020 18:09
@navarroaxel navarroaxel requested a review from sbrl October 6, 2020 11:29
@Amorymeltzer
Copy link
Contributor Author

All done @sbrl, thanks!

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Amorymeltzer! This is a great first page.

Next time, perhaps you could avoid force-pushing please? It makes it harder to tell what's changed when reviewing, and we've got a special button that allows us to squash easily on merge 😺

Either way, thanks for the new page ❤️

@sbrl sbrl merged commit 352c863 into tldr-pages:master Oct 7, 2020
@Amorymeltzer
Copy link
Contributor Author

Sure, no worries; I didn't see anything in the contributing guidelines about commit structures, but I probably should have guessed you all prefer the squash button, given the lack of merge commits. I personally love the "force-pushed" link, but I know not everyone does! Appreciate the speedy responses.

@sbrl
Copy link
Member

sbrl commented Oct 7, 2020

No worries! We actually prefer it if you don't force-push and squash, because in the GitHub web interface it makes it more difficult to see what's changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants