-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git-cherry: add page #4473
git-cherry: add page #4473
Conversation
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
bc605dd
to
d08ea59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new page, @Amorymeltzer! I've left some comments below for you to review. Hopefully I haven't changed the meaning too much 🙂
d08ea59
to
ea6d68b
Compare
Requested in tldr-pages#3953.
ea6d68b
to
12817c8
Compare
All done @sbrl, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Amorymeltzer! This is a great first page.
Next time, perhaps you could avoid force-pushing please? It makes it harder to tell what's changed when reviewing, and we've got a special button that allows us to squash easily on merge 😺
Either way, thanks for the new page ❤️
Sure, no worries; I didn't see anything in the contributing guidelines about commit structures, but I probably should have guessed you all prefer the squash button, given the lack of merge commits. I personally love the "force-pushed" link, but I know not everyone does! Appreciate the speedy responses. |
No worries! We actually prefer it if you don't force-push and squash, because in the GitHub web interface it makes it more difficult to see what's changed. |
Requested in #3953.
Opened as a draft as (IMO) the language feels a bit awkward, and would welcome suggestions.
common/
,linux/
, etc.)