Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-describe: add page #4413

Merged

Conversation

antoine-amara
Copy link
Contributor

Description

add a page for git describe command.
git describe is a command from the git scm software.

Linked Issues:

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@tldr-bot
Copy link

tldr-bot commented Oct 2, 2020

The build for this PR failed with the following error(s):

pages/common/git-describe.md:24 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
pages/common/git-describe.md:4: TLDR004 Command descriptions should end in a period
pages/common/git-describe.md:5: TLDR011 Page never contains more than a single empty line
pages/common/git-describe.md:20: TLDR005 Example descriptions should end in a colon
pages/common/git-describe.md:24: TLDR102 Example description probably not properly annotated

Please fix the error(s) and push again.

@antoine-amara antoine-amara force-pushed the page/git-describe-command branch from 6f62de9 to b11ffb4 Compare October 2, 2020 12:08
@sbrl sbrl added translation Translate pages from one language to another. new command Issues requesting creation of a new page or PRs adding a new page for a command. and removed translation Translate pages from one language to another. labels Oct 2, 2020
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new page, @antoine-amara! I've left some comments below for you to review.

pages/common/git-describe.md Outdated Show resolved Hide resolved
pages/common/git-describe.md Outdated Show resolved Hide resolved
pages/common/git-describe.md Outdated Show resolved Hide resolved
add a page for git describe command.
git describe is a command from the git scm software.
@antoine-amara antoine-amara force-pushed the page/git-describe-command branch from b11ffb4 to bf8cf88 Compare October 4, 2020 12:24
@antoine-amara
Copy link
Contributor Author

Thanks for the review @sbrl , I push the changes.

@navarroaxel navarroaxel changed the title git describe: add new page git-describe: add page Oct 4, 2020
@navarroaxel navarroaxel requested a review from sbrl October 4, 2020 13:24
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @antoine-amara!

Next time, perhaps you could avoid force-pushing please? It makes it harder to tell what's changed when reviewing, and we've got a special button that allows us to squash easily on merge 😺

@navarroaxel navarroaxel merged commit 7209394 into tldr-pages:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants