Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-stage: add page #3963

Merged
merged 4 commits into from
Apr 15, 2020
Merged

git-stage: add page #3963

merged 4 commits into from
Apr 15, 2020

Conversation

einverne
Copy link
Member

@einverne einverne commented Apr 3, 2020 •
edited
Loading

sbrl
sbrl requested changes Apr 3, 2020
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new page and edit, @einverne! I've left some comments below for you to review.

pages/common/git-add.md Outdated Show resolved Hide resolved
pages/common/git-stage.md Outdated Show resolved Hide resolved
pages/common/git-stage.md Outdated Show resolved Hide resolved
@owenvoke owenvoke added new command Issues requesting creation of a new page or PRs adding a new page for a command. page edit Changes to an existing page(s). labels Apr 6, 2020
sbrl
sbrl approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @einverne!

Oops, I really messed up one of my suggestions there. I've edited the last example in each page, if that's ok?

@sbrl sbrl merged commit 955a6b7 into tldr-pages:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Geipro Geipro Geipro approved these changes

@sbrl sbrl sbrl approved these changes

@zlatanvasovic zlatanvasovic zlatanvasovic approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command. page edit Changes to an existing page(s).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@einverne @zlatanvasovic @sbrl @Geipro @owenvoke