-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the OS list in README #3723
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrm, looks like this was merged before I got a chance to review.
I do recommend with documentation changes like the README, guidelines, etc. leaving them open for longer to allow all members to comment.
@@ -46,7 +46,7 @@ How about: | |||
![tldr screenshot](images/screenshot.png) | |||
|
|||
This repository is just that: an ever-growing collection of examples | |||
for the most common UNIX / Linux / macOS / SunOS commands. | |||
for the most common UNIX, Linux, OS X, SunOS and Windows commands. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not quite correct. The new name for OS X is macOS - this should be changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, that's true. I must have been out of date with this, as this has changed back in 2016. 😕
All right! Excuse me the inconvenience, @sbrl. I will keep this in mind for the next PR of the same type. |
No description provided.