Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the OS list in README #3723

Merged
merged 1 commit into from
Jan 1, 2020
Merged

Update the OS list in README #3723

merged 1 commit into from
Jan 1, 2020

Conversation

zlatanvasovic
Copy link
Contributor

No description provided.

@ivanhercaz ivanhercaz added the documentation Issues/PRs modifying the documentation. label Jan 1, 2020
Copy link
Collaborator

@Aracki Aracki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ivanhercaz ivanhercaz merged commit 330cb20 into master Jan 1, 2020
@Aracki Aracki deleted the zdroid-os branch January 1, 2020 19:25
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm, looks like this was merged before I got a chance to review.

I do recommend with documentation changes like the README, guidelines, etc. leaving them open for longer to allow all members to comment.

@@ -46,7 +46,7 @@ How about:
![tldr screenshot](images/screenshot.png)

This repository is just that: an ever-growing collection of examples
for the most common UNIX / Linux / macOS / SunOS commands.
for the most common UNIX, Linux, OS X, SunOS and Windows commands.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not quite correct. The new name for OS X is macOS - this should be changed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, that's true. I must have been out of date with this, as this has changed back in 2016. 😕

@sbrl sbrl mentioned this pull request Jan 3, 2020
@ivanhercaz
Copy link
Collaborator

Hrm, looks like this was merged before I got a chance to review.

I do recommend with documentation changes like the README, guidelines, etc. leaving them open for longer to allow all members to comment.

All right! Excuse me the inconvenience, @sbrl. I will keep this in mind for the next PR of the same type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues/PRs modifying the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants