Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sinfo: add link and improve examples #3700

Merged
merged 1 commit into from
Dec 28, 2019
Merged

sinfo: add link and improve examples #3700

merged 1 commit into from
Dec 28, 2019

Conversation

sbrl
Copy link
Member

@sbrl sbrl commented Dec 28, 2019

Behold! I now have access to my University's resident HPC (or, as I like to call it, supercomputer :D). It uses Slurm - so naturally I wrote a page on it. Checking though, it looks like we already have one - but since it uses the short-form options I thought I could do slightly better.

My University uses Slurm 15.08.8 for reference.

@sbrl sbrl added the page edit Changes to an existing page(s). label Dec 28, 2019
@ivanhercaz ivanhercaz merged commit 75d1094 into master Dec 28, 2019
@zlatanvasovic zlatanvasovic deleted the edit/sinfo branch December 28, 2019 18:05
@ivanhercaz
Copy link
Collaborator

This is the first time I merged a PR in this repository and I would like to know if I did it fine and if it is totally agree with the maintainer's guide. I decided to make a "squash and merge" because it is a just one commit, but if this PR would have been several commits for the same command I should apply the same action, no? But if this PR would have been several commits, each one for a different page, I should apply "rebase and merge". Am I right?

@zlatanvasovic
Copy link
Contributor

Yes, you did it all correctly. Rebase and merge cases are very rare, so if you are in doubt you can just squash and merge. They're supposed to be used with PRs labelled as mass changes.

@ivanhercaz
Copy link
Collaborator

Nice! So I understood it fine. Thank you @zdroid!

@agnivade
Copy link
Member

Merge is disabled.

And for the other two, glad you asked, because we have it well documented- https://github.com/tldr-pages/tldr/blob/master/contributing-guides/maintainers-guide.md#ii-handling-prs :)

Please go through all of the documentation and familiarize yourself. And feel free to ask for help in our gitter chat. Great to have you on the team !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
page edit Changes to an existing page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants