Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsb_release: add Spanish translation #3670

Merged
merged 3 commits into from
Dec 23, 2019

Conversation

ivanhercaz
Copy link
Collaborator

@ivanhercaz ivanhercaz commented Dec 20, 2019

  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.

@Geipro Geipro added the translation Translate pages from one language to another. label Dec 20, 2019
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks! I don't speak spanish, but thanks for the translation!

@ivanhercaz
Copy link
Collaborator Author

You're welcome, @sbrl! I hope to see a Spanish-speaker reviewing the translations I done. The translations are better when they are reviewed by more than one user. I will try to encourage some mate to join this awesome project.

@zlatanvasovic
Copy link
Contributor

@ivanhercaz If you get 5 own PRs merged, you'll be able to review the PRs of others yourself (see Community roles). 😄

@ivanhercaz
Copy link
Collaborator Author

ivanhercaz commented Dec 20, 2019

@ivanhercaz If you get 5 own PRs merged, you'll be able to review the PRs of others yourself (see Community roles).

Yes! I read it after to contribute with both PRs. It would be a pleasure to help in this project. Thank you for the information. I hope to contribute as much as possible ❤️

@zlatanvasovic
Copy link
Contributor

For some reason CLA bot doesn't work here. :o

@ivanhercaz
Copy link
Collaborator Author

ivanhercaz commented Dec 21, 2019

For some reason CLA bot doesn't work here. :o

It is something very strange. I sign #3669 without problems but in this case I didn't receive a message by CLA bot nor seem to be auto-signed. I thought it would sign automatically due I sign the another PR.

P.S.. @zdroid, it is a bit weird because the new PR I opened (#3675) is successfully signed.

@zlatanvasovic zlatanvasovic merged commit 8f3d006 into tldr-pages:master Dec 23, 2019
@zlatanvasovic
Copy link
Contributor

The trick worked. 🎉

@sbrl
Copy link
Member

sbrl commented Dec 24, 2019

Currently we don't have the detection process automated, so once you've got 5 PRs merged you may need to poke us on Gitter: https://gitter.im/tldr-pages/tldr :P

@zlatanvasovic
Copy link
Contributor

@sbrl You're a bit late to the party. #3690 #3691

@sbrl
Copy link
Member

sbrl commented Dec 24, 2019

I work through my notifications in chronological order, @zdroid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Translate pages from one language to another.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants