Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-check-ignore: add page #3113

Merged
merged 3 commits into from
Jun 17, 2019
Merged

git-check-ignore: add page #3113

merged 3 commits into from
Jun 17, 2019

Conversation

owenvoke
Copy link
Member

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@owenvoke owenvoke added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Jun 17, 2019
@tldr-bot

This comment has been minimized.

Sign in to view
Aracki
Aracki approved these changes Jun 17, 2019
View reviewed changes
Copy link
Collaborator

@Aracki Aracki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pxgamer, I didn't know about this command.

lgtm 👍

waldyrious
waldyrious reviewed Jun 17, 2019
View reviewed changes
pages/common/git-check-ignore.md

`git check-ignore {{path/to/file}} {{path/to/directory}}`

- Use pathnames, one per line, from stdin:
Copy link
Member

@waldyrious waldyrious Jun 17, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest using either STDIN or stdin (with backticks).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've previously chosen to lowercase stdin in the majority of pages. But I'll update it to use backticks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pxgamer make sense. Let's merge this one as-is and standardize stdin/stdout in a new PR :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'm working on that, btw)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: #3114

waldyrious
waldyrious approved these changes Jun 17, 2019
View reviewed changes
Copy link
Member

@waldyrious waldyrious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@waldyrious waldyrious merged commit 5284daa into tldr-pages:master Jun 17, 2019
@owenvoke owenvoke deleted the feature/git-check-ignore branch June 17, 2019 14:57
@waldyrious waldyrious mentioned this pull request Jun 17, 2019
Merged
@bl-ue bl-ue mentioned this pull request Jan 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waldyrious waldyrious waldyrious approved these changes

@Aracki Aracki Aracki approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@owenvoke @tldr-bot @waldyrious @Aracki