Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINTAINERS.md: update @pxgamer status #2997

Merged
merged 3 commits into from
May 14, 2019
Merged

MAINTAINERS.md: update @pxgamer status #2997

merged 3 commits into from
May 14, 2019

Conversation

owenvoke
Copy link
Member

@owenvoke owenvoke commented May 9, 2019

Closes #2989

@owenvoke owenvoke added the community Issues/PRs dealing with role changes and community organization. label May 9, 2019
@owenvoke owenvoke mentioned this pull request May 9, 2019
Closed
sbrl
sbrl approved these changes May 9, 2019
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@owenvoke
Copy link
Member Author

owenvoke commented May 9, 2019

See #2989 (comment) for some more details on the wording.

@owenvoke owenvoke force-pushed the feature/pxgamer-org-owner branch from bfd5beb to 650618e Compare May 10, 2019 11:36
@waldyrious
Copy link
Member

Let's wait for #3006 to be merged before merging this one, as discussed in #2989.

@sbrl
Copy link
Member

sbrl commented May 10, 2019

Ah, I see! Nevermind my comment in the other PR then - I see this PR will add @pxgamer back for historical reference 👍

@owenvoke
Copy link
Member Author

@waldyrious, I was just working on rebasing master into my branch 😂

Thanks for the merge!

@waldyrious
Copy link
Member

Sorry for wasting your time @pxgamer 😅. I wanted to try the web-based conflict resolution interface, which I hadn't tried before.

@waldyrious waldyrious merged commit daff9ba into tldr-pages:master May 14, 2019
@owenvoke owenvoke deleted the feature/pxgamer-org-owner branch May 14, 2019 13:16
@owenvoke
Copy link
Member Author

No waste of time at all. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrl sbrl sbrl approved these changes

@agnivade agnivade agnivade approved these changes

Assignees
No one assigned
Labels
community Issues/PRs dealing with role changes and community organization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add @pxgamer as an organisation owner
4 participants
@owenvoke @waldyrious @sbrl @agnivade