Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm access: add page #14400

Merged
merged 6 commits into from
Oct 28, 2024
Merged

npm access: add page #14400

merged 6 commits into from
Oct 28, 2024

Conversation

bharateshwq
Copy link
Contributor

@bharateshwq bharateshwq commented Oct 26, 2024

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Oct 26, 2024
@CLAassistant
Copy link

CLAassistant commented Oct 26, 2024

CLA assistant check
All committers have signed the CLA.

@sebastiaanspeck sebastiaanspeck changed the title added npm access page npm access: add page Oct 27, 2024
Copy link
Member

@sebastiaanspeck sebastiaanspeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pages/common/npm-access.md Outdated Show resolved Hide resolved
Copy link
Member

@Magrid0 Magrid0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the above suggestions

Co-authored-by: Sebastiaan Speck <[email protected]>
@bharateshwq bharateshwq changed the title npm access: add page npm access: add page #14000 Oct 27, 2024
@sebastiaanspeck sebastiaanspeck changed the title npm access: add page #14000 npm access: add page Oct 27, 2024
Copy link
Member

@sebastiaanspeck sebastiaanspeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My previous comment was to show you how we put placeholders in the commands and I hoped that you would fix it in the other examples as well.

@bharateshwq
Copy link
Contributor Author

Yeah sure I'm on it

@bharateshwq
Copy link
Contributor Author

Hi @sebastiaanspeck ,
They have been fixed can you check them now

pages/common/npm-access.md Outdated Show resolved Hide resolved
pages/common/npm-access.md Outdated Show resolved Hide resolved
bharateshwq and others added 2 commits October 27, 2024 17:57
Co-authored-by: Sebastiaan Speck <[email protected]>
Co-authored-by: Sebastiaan Speck <[email protected]>
Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bharateshwq
Copy link
Contributor Author

Hey @gutjuri ,
do you guys have slack or any other discussion groups i had few suggestions to discuss on the implementation

@sebastiaanspeck
Copy link
Member

Hey @gutjuri ,

do you guys have slack or any other discussion groups i had few suggestions to discuss on the implementation

We do, https://matrix.to/#/#tldr-pages:matrix.org

@gutjuri gutjuri mentioned this pull request Oct 28, 2024
6 tasks
@acuteenvy acuteenvy merged commit aa0352a into tldr-pages:main Oct 28, 2024
4 checks passed
@bharateshwq bharateshwq mentioned this pull request Oct 31, 2024
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants