Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcpkg: add page #12295

Merged
merged 6 commits into from
Feb 19, 2024
Merged

vcpkg: add page #12295

merged 6 commits into from
Feb 19, 2024

Conversation

iTrooz
Copy link
Contributor

@iTrooz iTrooz commented Feb 18, 2024 •
edited
Loading

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known): 2023-12-12-1c9ec1978a6b0c2b39c9e9554a96e3e275f7556e

@github-actions github-actions bot added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Feb 18, 2024
@tldr-bot

This comment was marked as resolved.

Sign in to view
vitorhcl
vitorhcl reviewed Feb 18, 2024
View reviewed changes
Copy link
Member

@vitorhcl vitorhcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I have some suggestions

pages/common/vcpkg.md Outdated Show resolved Hide resolved
pages/common/vcpkg.md Outdated Show resolved Hide resolved
pages/common/vcpkg.md Outdated Show resolved Hide resolved
pages/common/vcpkg.md Outdated Show resolved Hide resolved
pages/common/vcpkg.md Outdated Show resolved Hide resolved
pages/common/vcpkg.md Outdated Show resolved Hide resolved
pages/common/vcpkg.md Outdated Show resolved Hide resolved
kbdharun
kbdharun approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

LGTM, after @vitorhcl's suggestions above.

@kbdharun kbdharun requested a review from vitorhcl February 19, 2024 14:15
vitorhcl
vitorhcl approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@vitorhcl vitorhcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution and your patience!

@kbdharun kbdharun merged commit b6ebe64 into tldr-pages:main Feb 19, 2024
4 checks passed
@iTrooz iTrooz deleted the vcpkg branch February 19, 2024 14:23
@Managor Managor mentioned this pull request Oct 21, 2023
Open
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastiaanspeck sebastiaanspeck sebastiaanspeck left review comments

@kbdharun kbdharun kbdharun approved these changes

@vitorhcl vitorhcl vitorhcl approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iTrooz @tldr-bot @sebastiaanspeck @kbdharun @vitorhcl