Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-write-tree: add page #11584

Merged
merged 5 commits into from
Nov 27, 2023

Conversation

Muralikrishnan5971
Copy link
Contributor

@Muralikrishnan5971 Muralikrishnan5971 commented Nov 24, 2023

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Nov 24, 2023
@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/git-write-tree.md:11:37 MD047/single-trailing-newline Files should end with a single newline character
pages/common/git-write-tree.md:3: TLDR004 Command descriptions should end in a period
pages/common/git-write-tree.md:1: TLDR009 Page should contain a newline at end of file

Please fix the error(s) and push again.

@kbdharun kbdharun changed the title Add tldr page: git-write-tree git-write-tree: add page Nov 24, 2023
pages/common/git-write-tree.md Show resolved Hide resolved
pages/common/git-write-tree.md Show resolved Hide resolved
pages/common/git-write-tree.md Outdated Show resolved Hide resolved
@Muralikrishnan5971
Copy link
Contributor Author

@acuteenvy hi, not sure why Codespell / build (pull_request) check is failing. can you help ?

Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

Regarding the checks ... Maybe @sebastiaanspeck knows more

@acuteenvy
Copy link
Member

hi, not sure why Codespell / build (pull_request) check is failing. can you help ?

Your branch was ~700 commits behind main. I don't know why merging main fixed it but it seems to work now.

pages/common/git-write-tree.md Outdated Show resolved Hide resolved
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Welcome to tldr and thanks for your contribution.

@kbdharun kbdharun merged commit d28edb1 into tldr-pages:main Nov 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants