Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backbone network for RetinaNet #1

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

husseina-nvidia
Copy link

No description provided.

Copy link
Owner

@tkornuta-nvidia tkornuta-nvidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this is for sure a step in the right direction. However, there are still some improvements required, as follows:

  1. Full merge will involve using a script similar to the one that I have created, where:
  • there is a NeMo DataLayer object that feeds the batches to the model,
  • there is a Model that accepts those batches,
  • we use NeMo training.
  1. What I see now that forward() (which NeMo uses) is empty and you are calling some execute method, which is... I do not even understand what it is doing. Spanning many threads? What for? Where is forward step of the model?
  2. The wrapper is not "compatible" from I/O ports definition, please take a look at the FasterRCNN create_ports()

Finally, please add retinanet-examples package as a dependency to setup.py. How do you install it? Can it be installed through pip, right?

tkornuta-nvidia pushed a commit that referenced this pull request Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants