Skip to content

Commit

Permalink
Remove inferabilty of index_sizes helper test set.
Browse files Browse the repository at this point in the history
This set was introduced to test an inference issue (JuliaLang/julia#21244) in an old version of Julia.

It currently fails on Julia master because of JuliaLang/julia#27276.

In my opinion, it's currently not really testing anything valuable, and the Julia PR that fixed the issue has associated test cases that should cover this.
  • Loading branch information
tkoolen committed May 28, 2018
1 parent 446384a commit c1ff3cd
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions test/indexing.jl
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,4 @@
@test (zeros(0,2)[SVector{0,Int}(),SVector(1)] = 0) == 0
@test (zeros(2,0)[SVector(1),SVector{0,Int}()] = 0) == 0
end

@testset "inferabilty of index_sizes helper" begin
# see JuliaLang/julia#21244
# it's not about inferring the correct type, but about inference throwing an error
@test code_warntype(devnull, StaticArrays.index_sizes, Tuple{Vararg{Any}}) == nothing
end
end

0 comments on commit c1ff3cd

Please sign in to comment.