Remove docker in docker related workarounds #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tknerr
force-pushed
the
feature/remove-docker-in-docker-related-workarounds
branch
from
0589d69 to
3eb1651
Compare
tknerr
force-pushed
the
feature/remove-docker-in-docker-related-workarounds
branch
from
3eb1651 to
786a10d
Compare
… docker container
…eim/docker-systemctl-replacement to make systemd work in the docker baseimage
…t only when using the docker provider)
… in Vagrantfile This reverts commit 5b79b70.
|
All the docker related tests can successfully be run on CircleCI now. The build still fails but this is due to #88, which will be merged right after that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we are on CircleCI 2.0 and using "machine" vs "container", we should no longer need these fixes