Fix idempotence in subsequent Chef runs #79
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the
update-vm.sh
multiple times kept reinstalling Vagrant, Vagrant plugins as well as VirtualBox even though it was already installed.These were 3 different issues which broke idempotence:
dpkg_package
installation was missing a guard expression to check if the desired vagrant version is already installedinstall_vagrant_plugin(name, version)
helper function actually had a guard, but it was no longer working due to a change in the output ofvagrant plugin list
that we parseThis PR fixes the issues above, so that we have proper idempotence restored and subsequent Chef runs no longer reinstall the already installed stuff