fix JuliaLang#30030, assignment expr as named tuple element value (Ju…

…liaLang#30045)
tkf · Nov 21, 2018 · c755fcb · c755fcb
1 parent fbca2e5
commit c755fcb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/julia-syntax.scm b/src/julia-syntax.scm
@@ -1691,7 +1691,9 @@
 
 (define (named-tuple-expr names values)
   `(call (curly (core NamedTuple) (tuple ,@names))
-         (tuple ,@values)))
+         ;; NOTE: don't use `tuple` head, so an assignment expression as a value
+         ;; doesn't turn this into another named tuple.
+         (call (core tuple) ,@values)))
 
 (define (lower-named-tuple lst
                            (dup-error-fn (lambda (name) (string "field name \"" name "\" repeated in named tuple")))

diff --git a/test/syntax.jl b/test/syntax.jl
@@ -1758,3 +1758,9 @@ end
 @test Meta.isexpr(Meta.parse("1, \n"), :incomplete)
 @test_throws LoadError include_string(@__MODULE__, "1,")
 @test_throws LoadError include_string(@__MODULE__, "1,\n")
+
+# issue #30030
+let x = 0
+    @test (a=1, b=2, c=(x=3)) == (a=1, b=2, c=3)
+    @test x == 3
+end