Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance steam shortcut creation #366

Merged
merged 3 commits into from
Apr 15, 2020
Merged

Enhance steam shortcut creation #366

merged 3 commits into from
Apr 15, 2020

Conversation

Lucki
Copy link
Contributor

@Lucki Lucki commented Apr 15, 2020

This fixes #319 by correcting the node which the game gets added to.
It also presets the vertical image cover if one is available.

I've also added that all tags are added to the shortcut in hope they'll create the corresponding collections inside steam automatically but this doesn't work yet. Although adding the game inside steam to a collection adds the tag to the shortcut in the file this doesn't work the other way around.

@tkashkin
Copy link
Owner

Thanks for your contributions.

I'll merge your PRs and finally push dev branch into master.
I've pushed refactoring branch, but it's still WIP and not very usable at the moment.

@tkashkin tkashkin merged commit 57b25a7 into tkashkin:dev Apr 15, 2020
@Lucki Lucki deleted the issue-#319 branch April 16, 2020 10:16
@Lucki
Copy link
Contributor Author

Lucki commented Apr 16, 2020

I've pushed refactoring branch, but it's still WIP and not very usable at the moment.

That's quite a lot of changes :D
You want me to look into something or what's the reason behind publishing it already?

@tkashkin
Copy link
Owner

@Lucki I've pushed it just to be a bit more safe and to not accidentally lose any changes while merging. And to show that project is still alive.

You can see initial changes related to #304. Also some bugs may or may not have been fixed by rewriting.

Lucki pushed a commit to Lucki/GameHub that referenced this pull request Oct 30, 2021
Enhance steam shortcut creation

Former-commit-id: 57b25a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants