Orientation change and flash button added #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding button to activate/deactivate flash during the capturing the phase.
Added a method to turn on the camera's flash during the scanning process. Added some block in to handle the device orientation
Added a method to turn on the flash button
Fix the sigh light size on device orientation change
A change to activity configuration has been made to allow the orientation change.
|
Thanks Mica! I've merged your change into my own fork, since I didn't want to wait for tjwoon. Nice work! Prior to that, I also merged in Android M compatibility fixes from a different pull request. |
|
This looks really good! :) |
This was referenced Apr 14, 2016
|
Closing in favour of the rebased #65 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can you please keep in consideration these changes that I made.
I activated screen orientation on orientation change and a button to activate flash.