Add unixtimestamp32 to standard lib (microsoft#2579)

fix microsoft#2543
tjprescott · Oct 18, 2023 · 0801e17 · 0801e17
1 parent 8d24f2f
commit 0801e17
Show file tree

Hide file tree

Showing 3 changed files with 39 additions and 0 deletions.
diff --git a/packages/compiler/src/core/checker.ts b/packages/compiler/src/core/checker.ts
@@ -2678,6 +2678,7 @@ export function createChecker(program: Program): Checker {
           }
           for (const prop of node.properties) {
             if (prop.kind === SyntaxKind.ModelSpreadProperty) {
+              checkForSelfReference(prop, node);
               resolveAndCopyMembers(prop.target);
             } else {
               const name = prop.id.sv;
@@ -2737,6 +2738,29 @@ export function createChecker(program: Program): Checker {
         }
       }
 
+      function checkForSelfReference(node: ModelSpreadPropertyNode, parent: ModelStatementNode) {
+        let targetName = "";
+        let parentName = "";
+        if (node.target.target.kind === SyntaxKind.Identifier) {
+          targetName = node.target.target.sv;
+        }
+        if (parent.kind === SyntaxKind.ModelStatement) {
+          parentName = parent.id.sv;
+        }
+        if (parentName === "" || targetName === "") {
+          return;
+        }
+        if (parentName === targetName) {
+          reportCheckerDiagnostic(
+            createDiagnostic({
+              code: "spread-model",
+              messageId: "selfSpread",
+              target: node,
+            })
+          );
+        }
+      }
+
       function resolveAliasedSymbol(ref: Sym): Sym | undefined {
         const node = ref.declarations[0] as AliasStatementNode;
         switch (node.value.kind) {

diff --git a/packages/compiler/src/core/messages.ts b/packages/compiler/src/core/messages.ts
@@ -367,6 +367,7 @@ const diagnostics = {
     messages: {
       default: "Cannot spread properties of non-model type.",
       neverIndex: "Cannot spread type because it cannot hold properties.",
+      selfSpread: "Cannot spread type within its own declaration.",
     },
   },
   "unsupported-default": {

diff --git a/packages/compiler/test/checker/spread.test.ts b/packages/compiler/test/checker/spread.test.ts
@@ -65,6 +65,20 @@ describe("compiler: spread", () => {
     });
   });
 
+  it("emit diagnostic if model spreads itself", async () => {
+    const diagnostics = await runner.diagnose(`
+      model Foo {
+        ...Foo,
+        name: string,
+      }
+      `);
+
+    expectDiagnostics(diagnostics, {
+      code: "spread-model",
+      message: "Cannot spread type within its own declaration.",
+    });
+  });
+
   it("emit diagnostic if spreading scalar type", async () => {
     const diagnostics = await runner.diagnose(`
       model Foo {