Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON output object structure #24

Closed
tjc181 opened this issue Nov 29, 2023 · 1 comment
Closed

JSON output object structure #24

tjc181 opened this issue Nov 29, 2023 · 1 comment
Assignees
@tjc181
Labels
bug Something isn't working

Comments

@tjc181
Copy link
Owner

tjc181 commented Nov 29, 2023

The JSON output code produces a separate object with the same name "output" for every time period. This makes the full output unavailable to external tools parsing the file.

main.f90 line 164 seems to be the cause:

163:   IF (eq(TMOD,0.0)) then
164:      call json % create_object(out,'output')
165:      call json % add(p,out)
166:      CALL output(json, out, outputinit)
167:    end if
@tjc181 tjc181 self-assigned this Nov 29, 2023
@tjc181 tjc181 added the bug Something isn't working label Nov 29, 2023
tjc181 added a commit that referenced this issue Dec 5, 2023
@tjc181
Apply fix for JSON formatting, #24. Use an array with nested objects
141ddf0 
rather than multiple objects with a shared name.
@tjc181
Copy link
Owner Author

tjc181 commented Dec 6, 2023

Thanks to Rakesh Vadnathani for identifying this bug and confirming the fix.

@tjc181 tjc181 closed this as completed Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjc181 tjc181

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tjc181