Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what you did
Added
arm64
architecture compatibility.How you did it
Added an entry for the "arm64" architecture to the architecture
uname
case statement intarball_url()
. Actually, the string to look for in theuname
output isaarch64
, but on the nodejs site that architecture is called "arm64".How to verify it doesn't effect the functionality of n
On any machine on which the output of
uname
does not contain the string "aarch64", this PR will have no effect.If this solves an issue, please put issue in PR notes.
I never filed an issue for this.
If this solves an issue, please include the output of issue that had problems and then the fixed output from the same command.
If your machine is on this architecture (e.g. a Samsung Chromebook Plus), it previously would have worked like this:
After this change, it's more like this:
Squash any unnecessary commits to keep history clean as possible
Place description for the changelog in PR so we can tally all changes for any future release
"add detection for arm64/aarch64 architecture"