Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go modules for dependency tracking and fix broken dependency (go-env) #35

Merged
merged 4 commits into from
Sep 23, 2019

Conversation

zph
Copy link
Collaborator

@zph zph commented Sep 21, 2019

This pr introduces use of go mod for handling dependencies.

It also removes go-env, used in 1 location but broken in newer versions. I replaced it with stdlib code. Fixes warnings/error from mmake.go.

@zph
Copy link
Collaborator Author

zph commented Sep 21, 2019

(I think CI needs updating/debugging. make test and go build cmd/mmake/mmake.go are working locally)

@zph
Copy link
Collaborator Author

zph commented Sep 21, 2019

@tj I don't see a mechanism for me to update CI based on my Github contributor role. But I think it needs a little updating.

If you want to add me there, I can get it working again. I'd also be happy to set it up on Travis or Circle, both of which I'm familiar with.

@zph
Copy link
Collaborator Author

zph commented Sep 21, 2019

I believe the three currently correct steps in Semaphore, as of this PR are:

* `go mod download`
* `go build -v ./...`
* `go test -v ./...`

This step go get github.com/campoy/tools/tree can be dropped thanks to go mod handling those duties.

@tj
Copy link
Owner

tj commented Sep 23, 2019

hmm Semaphore seems messed, not getting any output, we could probably just use GH actions — I'll remove Semaphore for now :D

@tj tj merged commit 5f5d96e into master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants