-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented upload session APIs (multi-part uploads) #18
base: master
Are you sure you want to change the base?
Conversation
…nload() to content()
Strange failure, maybe manually retry? |
Ah yes, just remembered #2. So maybe the higher-level |
niceee, yea as much as possible I think the fancier stuff should be in go-dropy |
moved to go-dropy, see jpillora/go-dropy@5eee26d
Striped out high-level |
Adding new test with manually managed session upload... |
Semaphore seems to be a bit buggy, https://semaphoreci.com/tj/go-dropbox/branches/pull-request-18/builds/4 also failed strangely |
I'll sync with upstream again once #17 tests are fixed |
Changes
implemented auto-handled upload session method(see go-dropy)UploadSession()
download()
tocontent()
("Content-upload endpoints" and "Content-download endpoints")decodeContent()
helperPermanentlyDelete
endpoint path (not sure if it was incorrect on purpose?)Notes
files.go
, the raw upload session methods (start/append/finish) could be moved tofiles_upload_session.go
and then would becomeFiles.UploadSession.Start()
,.Append()
,.Finish()
- though we'd have to renameUploadSession()
to something else.PerformRetries bool
so if any chunk failed, it would be retransmitted. This would require aChunkSize
buffer though to hold data in case of failure and maybe the Dropbox API doesn't fail that often so it might not be worth it...