build: do not require the nonstandard and unpredictable 'which' utility #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may not be installed on various systems, and it's difficult to test for the availability of the tool you need, if the check program itself does not exist. The POSIX 2008 specification mandates the `command -v` builtin; bash is a POSIX 2008 compliant shell, and this builtin has worked since bash 1.x anyway. A side benefit of using the POSIX portable option is that it requires neither an external disk executable, nor (because unlike "which", the exit code is reliable) a subshell fork. This therefore represents a mild speedup.
|
Because I don't have |
|
Totally as a side note, the script doesn't actually make use of bash-specific features, so it could be modified to run via /bin/sh; it's not the only script in that situation. |
|
@eli-schwartz We only target to bash: https://github.com/tj/git-extras/blob/master/CONTRIBUTING.md#your-new-git-extra-command-should-support |
|
Yeah, probably makes sense I suppose. I'm just a persnickety /bin/sh script writer. :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may not be installed on various systems, and it's difficult to test for the availability of the tool you need, if the check program itself does not exist.
The POSIX 2008 specification mandates the
command -vbuiltin; bash is a POSIX 2008 compliant shell, and this builtin has worked since bash 1.x anyway.A side benefit of using the POSIX portable option is that it requires neither an external disk executable, nor (because unlike "which", the exit code is reliable) a subshell fork. This therefore represents a mild speedup.