Fix bugs with git-release --semver #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 7, 2018 14:44
The original regex will greedily match the first digit of version numbers that have multiple digits.
There is a bug in the current version: ``` version=1.1.3 ./git-release --semver minor version=1.2.3 ``` The correct behavior should be: ``` version=1.1.3 ./git-release --semver minor version=1.2.0 ```
spacewander
approved these changes
May 8, 2018
|
@tjaartvdwalt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found 2 bugs when using
git-release --semverThe version regex greedily matches only the first digit for version numbers that contain multiple digits. Matching the multi digit case first solves this problem.
When doing a
majorrelease, theminorandpatchversion numbers should be reset to0, and when doing aminorrelease, thepatchnumber should be reset to0.