Improve ignore-io #671
Merged
Improve ignore-io #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iterating through `a..z` omits entries starting with other characters.
ravidsrk
approved these changes
Oct 10, 2017
spacewander
requested changes
Oct 14, 2017
bin/git-ignore-io
Outdated
| echo | ||
| first_character=${ignorable:0:1} | ||
| if [[ $first_character = $previous_first_character ]]; then | ||
| printf " $ignorable" |
There was a problem hiding this comment.
Better to use printf " %s" "$ignoreable" to avoid format string injection.
bin/git-ignore-io
Outdated
| @@ -8,16 +8,26 @@ update_gi_list() { | |||
| } | |||
|
|
|||
| print_in_alphabetical_order() { | |||
| for i in {a..z}; | |||
| first=true | |||
There was a problem hiding this comment.
IMHO, it is better to declare local first ignorable first_character previous_first_character before using those variables in function, to avoid polluting outer variable scope.
|
@spacewander Thanks for the tips! Updated with those in mind. |
|
@sambostock |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes two improvements to
git ignore-io:git ignore-io -Lomitted entries which did not start witha..zgit ignore-io -L, in favour ofcolumn's default