pass tag and optional arguments to hook and stop if pre-release hook fails #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With some modification to catch up with latest situation. Signed-off-by: spacewander <[email protected]>
|
@spacewander Seems to be working just fine. A message on pre-release failure would be more descriptive IMHO. Something like "pre-release hook failed! Cancelling release" Thanks for taking time to implement this. |
|
@breneser |
|
@spacewander Yes, this works very nicely. Only one thing though, I think message should be written to stderr rather than stdout ? |
spacewander
force-pushed
the
pass-arguments-to-hooks
branch
from
38c1c9c to
2731092
Compare
|
@breneser |
|
@spacewander Great, thanks :) |
|
@spacewander any idea when this would be merged in ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is based on the work done in #192.
It is expected to fix #650 and other problem.
@breneser
Could you give this branch a try, and confirm whether the problems are fixed?