Adds 2FA support to git-fork #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
spacewander
reviewed
Jan 24, 2017
| ssh -o BatchMode=yes [email protected] exit >/dev/null 2>&1 | ||
| ssh_exit_code=$? | ||
| if [[ "$ssh_exit_code" = 0 ]] || [[ "$ssh_exit_code" = 1 ]]; then | ||
| if ssh -T [email protected] 2>&1 | grep -qi 'success'; then |
There was a problem hiding this comment.
Enter host password for user 'spacewander':
The authenticity of host 'github.com (192.30.253.112)' can't be established.
RSA key fingerprint is SHA256:nThbg6kXUpJWGl7E1IGOCspRomTxdCARLviKw6E5SY8.
Are you sure you want to continue connecting (yes/no)? no
Is there a way to disable the prompt?
There was a problem hiding this comment.
It seems possible. However doing so would expose the user to MITM attacks.
There was a problem hiding this comment.
Maybe we could tell users what will happen before ssh?
Just don't let them surprised.
There was a problem hiding this comment.
Sure, something like echo 'Add github remote as SSH (you will be prompted to verify the server's credentials)?'
There was a problem hiding this comment.
I think Add GitHub remote branch via SSH (you will be prompted to verify the server's credentials)? could be better.
There was a problem hiding this comment.
I added and rebased
|
Merged. |
|
You're welcome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two factor authentication support + minor linting