Make the win installer more robust #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User visible: * Also accept the git install path (and not the mingw64 subdir) as a user supplied install location. Make it the new default and warn the user if a mingw64 dir is supplied (=this dir is not checked, so it might be anywhere...) * Find git.exe in path and use that as an install location * Add error|status messages and output less noise (robocopy) * do some check if column.exe is not found... * adjust the installation text for windows... not user visible: * more.exe does not work when used in a cmd which has a unicode codepage -> save the current codepage and set a sane default during the install * do some "magic" with quotes around path variables -> makes it work with pathes with spaces in it (both final git dir and the git-extra checkout) * Do not leak variables to the sourounding interpreter
Merged
|
BTW: would it make sense to ask the git for windows people to include column.exe in the installer? |
|
@JanSchulz I think you have made a better one.:smile: |
|
I added a bug in git for windows to include column.exe: git-for-windows/git#586 |
|
👍 |
1 similar comment
|
👍 |
hemanth
added a commit
that referenced
this pull request
Jan 6, 2016
Make the win installer more robust
|
column.exe seems to get included in the git for windows installer: git-for-windows/build-extra#92 |
tardypad
pushed a commit
to tardypad/git-extras
that referenced
this pull request
Jul 13, 2016
Make the win installer more robust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User visible:
supplied install location. Make it the new default and warn the user if
a mingw64 dir is supplied (=this dir is not checked, so it might be
anywhere...)
not user visible:
-> save the current codepage and set a sane default during the install
pathes with spaces in it (both final git dir and the git-extra checkout)