Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-summary: protect against character encoding issues with LC_ALL=C #460

Merged
merged 1 commit into from
Oct 2, 2015
Merged

git-summary: protect against character encoding issues with LC_ALL=C #460

merged 1 commit into from
Oct 2, 2015

Conversation

apjanke
Copy link
Contributor

@apjanke apjanke commented Oct 2, 2015

On OS X 10.9.5, I get a couple sed errors in git-summary-line.

These look like character encoding issues.

[~/local/opp/omz/oh-my-zsh on ⇄ git-extras-compatibility]
$ git-summary --line

 project  : oh-my-zsh
sed: RE error: illegal byte sequence
sed: RE error: illegal byte sequence
 lines    : 34168
 authors  :
 3938 Andrew Janke              11.5%
 3374 Felipe Contreras          9.9%

Running sed under LC_ALL=C makes the errors go away. This PR does that.

@hemanth
Copy link
Collaborator

hemanth commented Oct 2, 2015

👍

hemanth added a commit that referenced this pull request Oct 2, 2015
git-summary: protect against character encoding issues with LC_ALL=C
@hemanth hemanth merged commit c4cd2ca into tj:master Oct 2, 2015
@apjanke apjanke deleted the summary-defensive-locale branch October 2, 2015 20:51
@qw3rtman qw3rtman mentioned this pull request Dec 27, 2015
tardypad pushed a commit to tardypad/git-extras that referenced this pull request Jul 13, 2016
git-summary: protect against character encoding issues with LC_ALL=C
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants