Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default make task to be install #425

Merged
merged 2 commits into from
Aug 20, 2015
Merged

Set default make task to be install #425

merged 2 commits into from
Aug 20, 2015

Conversation

nicolaiskogheim
Copy link
Collaborator

The default task for make now is docs, just because that task is defined earliest in the file.
This commit sets the default task explicitly to install. This is to avoid confusing people who want to build git-extras themselves.

This partially adresses #269

@hemanth
Copy link
Collaborator

hemanth commented Aug 8, 2015

Is there anyway to fix that fully?

@nicolaiskogheim
Copy link
Collaborator Author

Sorry, fix what?

17.15 Lør 8. Aug 2015 skrev hemanth.hm [email protected]:

Is there anyway to fix that fully?


Reply to this email directly or view it on GitHub
#425 (comment).

@hemanth
Copy link
Collaborator

hemanth commented Aug 8, 2015

ronn dependency.

@nicolaiskogheim
Copy link
Collaborator Author

Do you want to get rid of it, or just make it so that users doesn't have to
know about it?

17.36 Lør 8. Aug 2015 skrev hemanth.hm [email protected]:

ronn dependency.


Reply to this email directly or view it on GitHub
#425 (comment).

@hemanth
Copy link
Collaborator

hemanth commented Aug 9, 2015

If we can manage to gendocs without it, yes.

@spacewander
Copy link
Collaborator

So, will we write some scripts to replace ronn?

@hemanth
Copy link
Collaborator

hemanth commented Aug 10, 2015

So, will we write some scripts to replace ronn?

Would be great, but not sure of the complexity.

@@ -11,6 +11,8 @@ COMMANDS_USED_WITHOUT_GIT_REPO = git-alias git-extras git-fork git-setup
COMMANDS_USED_WITH_GIT_REPO = $(filter-out $(COMMANDS_USED_WITHOUT_GIT_REPO), \
$(subst bin/, , $(BINS)))

default: install

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be marked as .PHONY

@nicolaiskogheim
Copy link
Collaborator Author

Sorry for the delay here, guys.
default is now marked as .PHONY and this is ready to be merged as far as I am concerned.

I don't think we can or should remove ronn. We have to have something to generate our docs, but to create and maintain our own script in here would be wrong.
We just have to do what we can to make sure that regular users doesn't need to be bothered by it.

Edit: pushed the wrong button. Didn't mean to close.

@hemanth
Copy link
Collaborator

hemanth commented Aug 20, 2015

👍 Let merge this for now.

hemanth added a commit that referenced this pull request Aug 20, 2015
Set default make task to be install
@hemanth hemanth merged commit 6808b0f into tj:master Aug 20, 2015
@nicolaiskogheim nicolaiskogheim deleted the makefile-fix branch August 20, 2015 11:00
This was referenced Dec 27, 2015
tardypad pushed a commit to tardypad/git-extras that referenced this pull request Jul 13, 2016
Set default make task to be install
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants