-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default make task to be install #425
Conversation
Is there anyway to fix that fully? |
Sorry, fix what? 17.15 Lør 8. Aug 2015 skrev hemanth.hm [email protected]:
|
|
Do you want to get rid of it, or just make it so that users doesn't have to 17.36 Lør 8. Aug 2015 skrev hemanth.hm [email protected]:
|
If we can manage to gendocs without it, yes. |
So, will we write some scripts to replace |
Would be great, but not sure of the complexity. |
@@ -11,6 +11,8 @@ COMMANDS_USED_WITHOUT_GIT_REPO = git-alias git-extras git-fork git-setup | |||
COMMANDS_USED_WITH_GIT_REPO = $(filter-out $(COMMANDS_USED_WITHOUT_GIT_REPO), \ | |||
$(subst bin/, , $(BINS))) | |||
|
|||
default: install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be marked as .PHONY
Sorry for the delay here, guys. I don't think we can or should remove ronn. We have to have something to generate our docs, but to create and maintain our own script in here would be wrong. Edit: pushed the wrong button. Didn't mean to close. |
👍 Let merge this for now. |
Set default make task to be install
Set default make task to be install
The default task for
make
now isdocs
, just because that task is defined earliest in the file.This commit sets the default task explicitly to
install
. This is to avoid confusing people who want to build git-extras themselves.This partially adresses #269